From 8edd0566b8184e0534e3a55ebb722b20978d8417 Mon Sep 17 00:00:00 2001 From: murraydr Date: Wed, 1 Nov 2023 12:19:35 -0400 Subject: [PATCH] fixed crash with invalid email to GA when notifying them their helproom staff has changed. --- bugsAndFeatureRequests.txt | 9 ++++++++- helperFunctions.py | 1 + lastUpdatedToken.txt | 2 +- substitutionRequestForm.csv | 7 +++++++ 4 files changed, 17 insertions(+), 2 deletions(-) diff --git a/bugsAndFeatureRequests.txt b/bugsAndFeatureRequests.txt index c5dd431..2303c6e 100644 --- a/bugsAndFeatureRequests.txt +++ b/bugsAndFeatureRequests.txt @@ -1 +1,8 @@ -Put any discovered bugs or requests for new features here in this document so they aren't forgotten and I can fix/implement them when I'm in the office on Wednesdays. \ No newline at end of file +Put any discovered bugs or requests for new features here in this document so they aren't forgotten and I can fix/implement them when I'm in the office on Wednesdays. + +futureproofing calling float on single element helperfunctions.py 142 + +add email toggle to main requests + +crash on reject + diff --git a/helperFunctions.py b/helperFunctions.py index 863d052..7f510c3 100644 --- a/helperFunctions.py +++ b/helperFunctions.py @@ -410,6 +410,7 @@ def generateEmails(requestList): print(names,names!="NoShift") if names!="NoShift": recipient = nameToID(names[0]) + recipient = req[4]+"@msu.edu" subject="Change in helproom staff on "+date message="There has been a substitution in your helproom section: "+s+".\nYour ULAs on "+date+" are "+", ".join(names[1:]) diff --git a/lastUpdatedToken.txt b/lastUpdatedToken.txt index d63aa4f..0a97c32 100644 --- a/lastUpdatedToken.txt +++ b/lastUpdatedToken.txt @@ -1 +1 @@ -2023-10-25 15:47:03.083140 \ No newline at end of file +2023-11-01 09:40:03.046218 \ No newline at end of file diff --git a/substitutionRequestForm.csv b/substitutionRequestForm.csv index e5d380a..827bb25 100644 --- a/substitutionRequestForm.csv +++ b/substitutionRequestForm.csv @@ -1,3 +1,10 @@ Timestamp,Requestor,Section,Dates,Replacement,Reason 2023-10-25 16:36:16.765000,austi143,Sec 11,10/25,lnumehak,Covid vax side effects 2023-10-25 19:04:11.218000,allarde2,Sec 34,10/26,bhardw41,I have strep throat. +2023-10-26 13:27:58.149000,bhardw41,R_HR1;R_HR2;Sec 35,10/26,,Illness +2023-10-29 22:11:26.524000,allarde2,S_HR1;S_HR2,10/29,,Strep Throat +2023-10-29 22:33:50.788000,burgejae,S_HR1;S_HR2,10/29,bhardw41,Not feeling well +2023-10-30 03:49:03.509000,straskra,Sec 24,10/30,,Mom is visiting from Hawaii and wants to spend some time with me +2023-10-30 11:24:57.749000,sonarsoh,Sec 17,10/30,kumararn,Driving back from home +2023-10-31 14:36:00.255000,khanalpr,Sec 51,08/31,,Fever and body pain due to vaccination. +2023-10-31 16:16:16.466000,guruswa1,T_HR1;T_HR2;Sec 6,10/31,rahman64,Sick with migraine and fever. Need time to rest and recover.